homepage

The test CheckCollationIsUsed in Lib/sqlite3/test/hooks.py never runs because it checks the wrong version tuple. Patch attached.

It might be good to add some documentation to the sqlite3 module and describe that version_info is only the PYSQLITE_VERSION and not the version of the sqlite library.

poq, would you like to also prepare a patch for the documentation with what Thomas suggested? I'd be happy to review when ready

Sure, why not. Here you go.

Thanks! The code patch should use unittest.skip instead of return (even if the rest of the file uses return, we can improve that one step at a time).

Now with proper skipping.

Both patches LGTM.

poq: I see you have submitted a few other patches to the tracker, too. For us to be able to use your patches, you should sign the PSF Contributor Agreement as described here: http://www.python.org/psf/contrib/.

New changeset b8b26feb3e1a by R David Murray in branch '3.2':
#13934: document sqlite version strings, use correct one in test.
http://hg.python.org/cpython/rev/b8b26feb3e1a
New changeset cdf9142a0c84 by R David Murray in branch '3.3':
merge #13934: document sqlite version strings, use correct one in test.
http://hg.python.org/cpython/rev/cdf9142a0c84
New changeset aef7db0d3893 by R David Murray in branch 'default':
merge #13934: document sqlite version strings, use correct one in test.
http://hg.python.org/cpython/rev/aef7db0d3893
New changeset 315949b1842e by R David Murray in branch '2.7':
#13934: document sqlite version strings.
http://hg.python.org/cpython/rev/315949b1842e 

These patches are small enough a contributor agreement is not required, but it would still be great if you would submit one, poq.

Thanks for the report and patches!