This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2012年01月18日 10:43 by yak, last changed 2022年04月11日 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| design.patch | zektron42, 2015年04月13日 20:26 | This should add in some documentation to the design faqs | review | |
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 26835 | merged | terry.reedy, 2021年06月21日 19:53 | |
| PR 26836 | merged | miss-islington, 2021年06月21日 21:23 | |
| PR 26837 | merged | miss-islington, 2021年06月21日 21:23 | |
| Messages (10) | |||
|---|---|---|---|
| msg151530 - (view) | Author: Arkadiusz Wahlig (yak) | Date: 2012年01月18日 10:43 | |
Generators should support the with statement with __exit__ calling self.close(). with genfunc() as g: for item in g: print(item) |
|||
| msg151532 - (view) | Author: Ezio Melotti (ezio.melotti) * (Python committer) | Date: 2012年01月18日 10:57 | |
If you want to call .close() automatically on something you can use contextlib.closing(): http://docs.python.org/library/contextlib.html#contextlib.closing |
|||
| msg151717 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2012年01月21日 04:03 | |
Calling g.close() is pointless for a generator used in normal pull mode and run to completion, as in the example. The generator is already 'closed', so g.close() does not do anything useful. See http://docs.python.org/py3k/reference/expressions.html#yield-expressions The method was added to be used with .send() so that generators used in push mode could be told to finish up when there is nothing more to send. For such rare uses, contextlib.closing should usually be sufficient, I think. So I think this issue should be closed. |
|||
| msg151763 - (view) | Author: Alyssa Coghlan (ncoghlan) * (Python committer) | Date: 2012年01月22日 06:58 | |
Generators deliberately don't support the context management protocol. This is so that they raise an explicit TypeError or AttributeError (pointing out that __exit__ is missing) if you leave out the @contextmanager decorator when you're using a generator to write an actual context manager. Generators supporting the context management protocol natively would turn that into a far more subtle (and confusing) error: your code would silently fail to invoke the generator body. Ensuring this common error remains easy to detect is far more important than making it easier to invoke close() on a generator object (particularly when contextlib.closing() already makes that very easy). |
|||
| msg240820 - (view) | Author: R. David Murray (r.david.murray) * (Python committer) | Date: 2015年04月14日 00:54 | |
Looks like the right approach, I hadn't thought of the design FAQ, but it makes sense as a place to put it. I made a couple of review comments. |
|||
| msg396285 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2021年06月21日 19:54 | |
I added a simplified answer after a similar question about assignment and CMs. |
|||
| msg396290 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2021年06月21日 21:23 | |
New changeset 51f45d085dad3b708f6fe166af517aba69e7e9f7 by Terry Jan Reedy in branch 'main': bpo-13814: Explain why generators are not context managers (GH-26835) https://github.com/python/cpython/commit/51f45d085dad3b708f6fe166af517aba69e7e9f7 |
|||
| msg396293 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2021年06月21日 22:02 | |
New changeset 1e16217204c0e8e595c4d1e869c81899bfe3376b by Miss Islington (bot) in branch '3.10': bpo-13814: Explain why generators are not context managers (GH-26835) https://github.com/python/cpython/commit/1e16217204c0e8e595c4d1e869c81899bfe3376b |
|||
| msg396294 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2021年06月21日 22:03 | |
New changeset d881002fbdf12ddbd93db3e182dc5cdeb1f90386 by Miss Islington (bot) in branch '3.9': bpo-13814: Explain why generators are not context managers (GH-26835) https://github.com/python/cpython/commit/d881002fbdf12ddbd93db3e182dc5cdeb1f90386 |
|||
| msg396552 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2021年06月26日 14:49 | |
Note: Rietveld patch reviews are no longer accessible so I could not look at R. David's comments. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:25 | admin | set | github: 58022 |
| 2021年06月26日 14:49:27 | terry.reedy | set | messages: + msg396552 |
| 2021年06月21日 22:03:33 | terry.reedy | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2021年06月21日 22:03:09 | terry.reedy | set | messages: + msg396294 |
| 2021年06月21日 22:02:50 | terry.reedy | set | messages: + msg396293 |
| 2021年06月21日 21:23:44 | miss-islington | set | pull_requests: + pull_request25418 |
| 2021年06月21日 21:23:38 | miss-islington | set | nosy:
+ miss-islington pull_requests: + pull_request25417 |
| 2021年06月21日 21:23:36 | terry.reedy | set | messages: + msg396290 |
| 2021年06月21日 19:54:08 | terry.reedy | set | keywords:
- easy messages: + msg396285 |
| 2021年06月21日 19:53:30 | terry.reedy | set | keywords:
+ patch pull_requests: + pull_request25416 |
| 2021年06月21日 17:33:50 | iritkatriel | set | keywords:
+ easy, - patch versions: + Python 3.9, Python 3.10, Python 3.11, - Python 3.5, Python 3.6 |
| 2016年01月02日 08:58:08 | ezio.melotti | set | stage: needs patch -> patch review versions: + Python 3.5, Python 3.6, - Python 3.4 |
| 2015年04月22日 04:05:41 | martin.panter | set | nosy:
+ martin.panter |
| 2015年04月14日 00:54:29 | r.david.murray | set | nosy:
+ r.david.murray messages: + msg240820 |
| 2015年04月13日 20:26:38 | zektron42 | set | files:
+ design.patch keywords: + patch versions: + Python 3.4, - Python 3.3 |
| 2012年01月22日 15:51:35 | meador.inge | set | nosy:
+ meador.inge |
| 2012年01月22日 06:58:16 | ncoghlan | set | status: pending -> open assignee: docs@python components: + Documentation title: Generators as context managers. -> Document why generators don't support the context management protocol nosy: + docs@python messages: + msg151763 stage: test needed -> needs patch |
| 2012年01月21日 04:03:30 | terry.reedy | set | status: open -> pending nosy: + terry.reedy messages: + msg151717 stage: test needed |
| 2012年01月20日 15:07:39 | pitrou | set | nosy:
+ ncoghlan versions: + Python 3.3, - Python 2.7, Python 3.4 |
| 2012年01月18日 10:57:59 | ezio.melotti | set | nosy:
+ ezio.melotti messages: + msg151532 |
| 2012年01月18日 10:43:15 | yak | create | |