This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2011年12月28日 14:13 by andrea.crotti, last changed 2022年04月11日 14:57 by admin.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| test_pstats.diff | andrea.crotti, 2011年12月28日 14:13 | review | ||
| Messages (6) | |||
|---|---|---|---|
| msg150290 - (view) | Author: andrea crotti (andrea.crotti) | Date: 2011年12月28日 14:13 | |
This patch increases test coverage for pstats.py from 25 to 36%. It's my first proposed patch so sorry in advance if there are problems. Much more can be done for pstats.py (which is also not much commented) but I want to get some feedback on this first.. |
|||
| msg150291 - (view) | Author: Georg Brandl (georg.brandl) * (Python committer) | Date: 2011年12月28日 15:12 | |
I don't understand this comment: + #TODO: add more complicated tests, which might almost compile Also, please don't use docstrings for the test methods because of unittest's "feature" to display them instead of the test method names. |
|||
| msg150292 - (view) | Author: andrea crotti (andrea.crotti) | Date: 2011年12月28日 15:36 | |
It's really hard to understand true, and if should not go in the patch in general of course. The sense was that the only test I added is trivial, but I haven't produced something better yet. And ok I will remove the docstrings, I was actually doing it on purpose thinking about the unittest feature, but if the name is clear enough than is better to leave the docstring out... Another thing, I didn't want to use tempfile.mktemp to generate a temporary file, but dump_stats doesn't accept anything else, is it in general safe to use it in this case? |
|||
| msg221790 - (view) | Author: Mark Lawrence (BreamoreBoy) * | Date: 2014年06月28日 14:08 | |
@Andrea assuming that you get an answer to the question you posed in msg150292, will you follow up on this? |
|||
| msg338076 - (view) | Author: andrea crotti (andrea.crotti) | Date: 2019年03月16日 10:10 | |
It has been a long time but if it's still useful sure. I can see some tests have been added in commit 863b1e4d0e95036bca4e97c1b8b2ca72c19790fb but if these are still relevant I'm happy to go ahead. |
|||
| msg415821 - (view) | Author: Irit Katriel (iritkatriel) * (Python committer) | Date: 2022年03月22日 21:55 | |
The patch needs to be reviewed. If the tests are still relevant and increase coverage, it needs to be converted to a GitHub PR. Otherwise this issue can be closed. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:25 | admin | set | github: 57879 |
| 2022年03月22日 21:55:07 | iritkatriel | set | keywords:
+ easy, newcomer friendly, - patch nosy: + iritkatriel messages: + msg415821 |
| 2019年03月16日 10:10:25 | andrea.crotti | set | messages: + msg338076 |
| 2019年03月16日 00:01:44 | BreamoreBoy | set | nosy:
- BreamoreBoy |
| 2014年06月28日 14:08:59 | BreamoreBoy | set | nosy:
+ BreamoreBoy messages: + msg221790 versions: + Python 3.5, - Python 3.3 |
| 2011年12月28日 15:36:53 | andrea.crotti | set | messages: + msg150292 |
| 2011年12月28日 15:12:00 | georg.brandl | set | nosy:
+ georg.brandl messages: + msg150291 |
| 2011年12月28日 14:57:41 | brian.curtin | set | nosy:
+ brian.curtin stage: patch review |
| 2011年12月28日 14:13:28 | andrea.crotti | create | |