This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2011年11月22日 19:02 by r.david.murray, last changed 2022年04月11日 14:57 by admin.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| response_class.http.client.patch | angad, 2015年07月04日 07:23 | review | ||
| Messages (4) | |||
|---|---|---|---|
| msg148136 - (view) | Author: R. David Murray (r.david.murray) * (Python committer) | Date: 2011年11月22日 19:02 | |
The doc string for HTTPConnection.getresponse mentions (in broken English) that the instance's response_class attribute determines what class gets instantiated for a response. The docs do not mention this attribute, nor any other way to control what class is used. Since this attribute already exists and is mentioned in the doc string, can we consider this a doc error and just document it? |
|||
| msg221807 - (view) | Author: Mark Lawrence (BreamoreBoy) * | Date: 2014年06月28日 18:21 | |
ping. |
|||
| msg246241 - (view) | Author: Angad Singh (angad) * | Date: 2015年07月04日 07:23 | |
I have a patch for this. I have also documented some of the non-documented attributes of HTTPConnection class. |
|||
| msg246388 - (view) | Author: Martin Panter (martin.panter) * (Python committer) | Date: 2015年07月07日 01:01 | |
Why do people want "response_class" to be part of the API? If so, more details about it may need to added, e.g. the following methods and attributes seem to be required: _read_status(), fp, close(), isclosed(), begin() and will_close. The "debuglevel" attribute seems fairly redundant with the existing set_debuglevel() method. Also, what is the point of adding the "default_port" attribute, if it cannot be modified? The only use case I can imagine is in a subclass that specifically does modify it. But I’m not sure it should be added at all. So I am sorry, but I don’t see why any of the three additions in the patch should be made. IMO it would be better to explain that "response_class" is an internal implementation detail, or even drop it entirely from the doc string. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:24 | admin | set | github: 57665 |
| 2019年02月24日 22:59:50 | BreamoreBoy | set | nosy:
- BreamoreBoy |
| 2015年07月07日 01:01:38 | martin.panter | set | nosy:
+ martin.panter messages: + msg246388 |
| 2015年07月04日 10:32:39 | berker.peksag | set | nosy:
+ berker.peksag stage: patch review type: enhancement versions: + Python 3.4, Python 3.5, Python 3.6, - Python 3.2, Python 3.3 |
| 2015年07月04日 07:23:02 | angad | set | files:
+ response_class.http.client.patch nosy: + angad messages: + msg246241 keywords: + patch |
| 2014年06月28日 18:21:36 | BreamoreBoy | set | nosy:
+ BreamoreBoy messages: + msg221807 |
| 2011年11月22日 19:02:13 | r.david.murray | create | |