homepage

>>> bytearray(b'abc').count(bytearray(b''), None)
Traceback (most recent call last):
 File "<stdin>", line 1, in <module>
TypeError: slice indices must be integers or None or have an __index__ method
>>> bytearray(b'abc').find(bytearray(b''), None)
Traceback (most recent call last):
 File "<stdin>", line 1, in <module>
TypeError: slice indices must be integers or None or have an __index__ method
>>> bytearray(b'abc').index(bytearray(b''), None)
Traceback (most recent call last):
 File "<stdin>", line 1, in <module>
TypeError: slice indices must be integers or None or have an __index__ method
and duplicate issues (endswith and startswith):
>>> bytearray(b'abc').endswith(bytearray(b''), None)
Traceback (most recent call last):
 File "<stdin>", line 1, in <module>
TypeError: slice indices must be integers or None or have an __index__ method
>>> bytearray(b'abc').startswith(bytearray(b''), None)
Traceback (most recent call last):
 File "<stdin>", line 1, in <module>
TypeError: slice indices must be integers or None or have an __index__ method
>>>

As Raymond said in another issue, someone should fix this once and for all by factoring this check out into a reusable method and making sure it is used everywhere.

Note that both of these have been fixed in default, so I'm repurposing this issue for the refactoring I suggested. However, since I can't find an existing issue for the bytearray fix, maybe somebody already did it and I didn't notice.

I started working on this. But found sliceobject.c. Think it would be a good idea to add the refactored functions there. Anyway, i was trying to figure out the functionality of sliceobject.c. Can someone put up a use/test case example for it? Thanks for patience with my newbieness to python source

R. David Murray wrote:
> Note that both of these have been fixed in default, so I'm
> repurposing this issue for the refactoring I suggested.
> However, since I can't find an existing issue for the bytearray
> fix, maybe somebody already did it and I didn't notice.
It seems to me that such refactorization has been already done when fixing issue 11828. The stringlib_parse_args_finds() function is used to to parse the slice-like arguments of str, bytes and bytearray functions.
As the errors reported in the issue have already been fixed in all branches, I'm closing this as invalid.