This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2011年03月01日 18:50 by sandro.tosi, last changed 2022年04月11日 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| curses_missing_functs-py3k.patch | sandro.tosi, 2011年03月01日 18:50 | |||
| curses_doc_update.diff | sandro.tosi, 2011年06月26日 09:58 | review | ||
| curses_missing_functs-py3k-v2.patch | sandro.tosi, 2011年06月26日 10:13 | review | ||
| Messages (10) | |||
|---|---|---|---|
| msg129791 - (view) | Author: Sandro Tosi (sandro.tosi) * (Python committer) | Date: 2011年03月01日 18:50 | |
Following up http://mail.python.org/pipermail/docs/2011-January/002922.html , I did a check on all the documented functions of curses and those available from the module, and wrote a patch to include in the doc the missing ones (text is mainly brought by manpages). IMHO, it should be backported to the currently maintained versions (but I didn't check what's 2.7 status). |
|||
| msg129793 - (view) | Author: Sandro Tosi (sandro.tosi) * (Python committer) | Date: 2011年03月01日 18:53 | |
On Tue, Mar 1, 2011 at 19:50, Sandro Tosi <report@bugs.python.org> wrote: > > New submission from Sandro Tosi <sandro.tosi@gmail.com>: > > Following up http://mail.python.org/pipermail/docs/2011-January/002922.html , I did a check on all the documented functions of curses and those available from the module, and wrote a patch to include in the doc the missing ones (text is mainly brought by manpages). > > IMHO, it should be backported to the currently maintained versions (but I didn't check what's 2.7 status). I did it now, it was quite easy: diff between 2.7 and py3k doc files are just a bunch of line, and patch applies fine (with some hunk offsets) on release2.7-maint too. |
|||
| msg139158 - (view) | Author: Sandro Tosi (sandro.tosi) * (Python committer) | Date: 2011年06月26日 09:58 | |
As requested by Ezio, I'm attaching a "pre-patch" to bring curses doc a bit more adherent to current standards like by s/Returns/Return/ , ``True`` instead of true and so on. It applies ok on 3.3 and 3.2, on 2.7 a hunk is failing (but Ezio said it's fine this way :)). After this patch is applies, the previous one (to add missing functs) can be applied. |
|||
| msg139159 - (view) | Author: Sandro Tosi (sandro.tosi) * (Python committer) | Date: 2011年06月26日 10:13 | |
Still following Ezio suggestion, I've reworked a bit the original patch, attaching its -v2 . |
|||
| msg139163 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2011年06月26日 10:39 | |
New changeset 3eb9c31a0b03 by Ezio Melotti in branch '2.7': #11363: clean up curses doc. http://hg.python.org/cpython/rev/3eb9c31a0b03 New changeset 3dc602b1f4a2 by Ezio Melotti in branch '2.7': #11363: add missing functions from curses doc. Patch by Sandro Tosi. http://hg.python.org/cpython/rev/3dc602b1f4a2 New changeset bb27baa1124a by Ezio Melotti in branch '3.2': #11363: clean up curses doc. http://hg.python.org/cpython/rev/bb27baa1124a New changeset f852e2d556af by Ezio Melotti in branch '3.2': #11363: add missing functions from curses doc. Patch by Sandro Tosi. http://hg.python.org/cpython/rev/f852e2d556af New changeset b879bad40154 by Ezio Melotti in branch 'default': #11363: merge with 3.2. http://hg.python.org/cpython/rev/b879bad40154 |
|||
| msg139164 - (view) | Author: Ezio Melotti (ezio.melotti) * (Python committer) | Date: 2011年06月26日 10:41 | |
Fixed, thanks for the patch! |
|||
| msg139426 - (view) | Author: Éric Araujo (eric.araujo) * (Python committer) | Date: 2011年06月29日 15:17 | |
A typo slipped into the 3.2 commit: x``'033円[6;4H'`` In addition, I tried the example in my shell and got a bytes/str error; that’s probably another report. |
|||
| msg139443 - (view) | Author: Sandro Tosi (sandro.tosi) * (Python committer) | Date: 2011年06月29日 18:16 | |
I think the same typo is also on default (since merged from 3.2): Ezio, do you want me to upload a patch or you'll fix it? Éric: I can see the tparm() example is failing, since tgetstr() is returning bytes while it expects a string: did you already file about about it? want me to? |
|||
| msg139658 - (view) | Author: Éric Araujo (eric.araujo) * (Python committer) | Date: 2011年07月02日 14:39 | |
Yes, the typo is also on default; I did not mention it, as the merge would have shown it :) I did not report the bug I found; if you could test all examples for 3.x-compat and open a report, it would be great. |
|||
| msg140787 - (view) | Author: Ezio Melotti (ezio.melotti) * (Python committer) | Date: 2011年07月21日 05:58 | |
FWIW the typo has been fixed in 13c9b93e97ad. If the example is failing another issue should be created. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:13 | admin | set | github: 55572 |
| 2011年07月21日 05:58:37 | ezio.melotti | set | status: open -> closed messages: + msg140787 |
| 2011年07月02日 14:39:18 | eric.araujo | set | messages: + msg139658 |
| 2011年06月29日 18:16:18 | sandro.tosi | set | messages: + msg139443 |
| 2011年06月29日 15:17:27 | eric.araujo | set | status: closed -> open nosy: + eric.araujo messages: + msg139426 |
| 2011年06月26日 10:41:51 | ezio.melotti | set | status: open -> closed messages: + msg139164 assignee: docs@python -> ezio.melotti resolution: fixed stage: patch review -> resolved |
| 2011年06月26日 10:39:57 | python-dev | set | nosy:
+ python-dev messages: + msg139163 |
| 2011年06月26日 10:13:04 | sandro.tosi | set | files:
+ curses_missing_functs-py3k-v2.patch messages: + msg139159 |
| 2011年06月26日 09:58:14 | sandro.tosi | set | files:
+ curses_doc_update.diff versions: - Python 3.1 nosy: + ezio.melotti messages: + msg139158 |
| 2011年03月01日 18:53:23 | sandro.tosi | set | messages: + msg129793 |
| 2011年03月01日 18:50:01 | sandro.tosi | create | |