This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2010年10月31日 15:03 by bbrazil, last changed 2022年04月11日 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| sunau_fd_leak.patch | bbrazil, 2010年10月31日 15:19 | |||
| sunau_fd_leak_v2.patch | bbrazil, 2010年10月31日 16:06 | |||
| Messages (6) | |||
|---|---|---|---|
| msg120049 - (view) | Author: Brian Brazil (bbrazil) * | Date: 2010年10月31日 15:03 | |
Please see attached. It's possible that this change will lead to fds leaking if someone is passing in a fd, however a) this is consistent with how other modules (e.g. uu) do it and b) of the 2 (!) uses of this module I found on Google Codesearch, both pass in filenames. |
|||
| msg120051 - (view) | Author: Brian Curtin (brian.curtin) * (Python committer) | Date: 2010年10月31日 15:07 | |
Forget the attachment? |
|||
| msg120056 - (view) | Author: Brian Brazil (bbrazil) * | Date: 2010年10月31日 15:19 | |
That'd help alright. |
|||
| msg120061 - (view) | Author: Antoine Pitrou (pitrou) * (Python committer) | Date: 2010年10月31日 15:36 | |
> It's possible that this change will lead to fds leaking if someone is > passing in a fd I don't think so, why do you say that? That said, there's an indentation problem in your patch. |
|||
| msg120066 - (view) | Author: Brian Brazil (bbrazil) * | Date: 2010年10月31日 16:06 | |
Currently, if you pass in a fd it'll be closed by the __del__. My patch no longer does this so any use of the module depending on this behaviour could leak an fd. However, noone seems to use the module that way. V2 attached. |
|||
| msg120087 - (view) | Author: Antoine Pitrou (pitrou) * (Python committer) | Date: 2010年10月31日 21:27 | |
Committed in r86067. Thank you Brian! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:08 | admin | set | github: 54474 |
| 2010年10月31日 21:27:21 | pitrou | set | status: open -> closed resolution: fixed messages: + msg120087 stage: resolved |
| 2010年10月31日 16:06:02 | bbrazil | set | files:
+ sunau_fd_leak_v2.patch messages: + msg120066 |
| 2010年10月31日 15:36:08 | pitrou | set | nosy:
+ pitrou messages: + msg120061 |
| 2010年10月31日 15:19:19 | bbrazil | set | files:
+ sunau_fd_leak.patch keywords: + patch messages: + msg120056 |
| 2010年10月31日 15:07:19 | brian.curtin | set | versions:
+ Python 3.2, - Python 3.3 nosy: + brian.curtin messages: + msg120051 type: resource usage |
| 2010年10月31日 15:03:31 | bbrazil | create | |